Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasets] Remove "Example: Large-scale ML Ingest" #33067

Merged
merged 25 commits into from
Mar 15, 2023
Merged

[Datasets] Remove "Example: Large-scale ML Ingest" #33067

merged 25 commits into from
Mar 15, 2023

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Mar 6, 2023 •
edited
Loading

Depends on:

Why are these changes needed?

"Example: Large-scale ML ingest" is obsolete with the introduction of “Configuring Ingest” and the planned removal of dataset pipelines. This PR removes the example.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
3db9875 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Remove big_data_ingestion.ipynb
94e12bb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'ml-preprocessing-revisions' into remove-example
c2c5f46 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani and others added 11 commits March 6, 2023 15:15
@bveeramani @angelinalg
Update doc/source/data/transforming-datasets.rst
32abf7b 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/transforming-datasets.rst
833c2a1 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/transforming-datasets.rst
4edad33 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/dataset.rst
fc10610 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/dataset.rst
393fc40 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/dataset.rst
520b0df 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/dataset.rst
3849ab3 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @angelinalg
Update doc/source/data/transforming-datasets.rst
68bbfa1 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani
Update dataset.rst
781819f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update transforming-datasets.rst
1d0d62a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'ml-preprocessing-revisions' of https://github.com/bveer…
d81b0be 
…amani/ray into ml-preprocessing-revisions

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
c21 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code deletion part in this PR looks good to me.

bveeramani and others added 11 commits March 10, 2023 10:24
@bveeramani @clarkzinzow
Update doc/source/ray-air/check-ingest.rst
5d31afb 
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @clarkzinzow
Update doc/source/data/dataset.rst
f8c191c 
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani @clarkzinzow
Update doc/source/data/transforming-datasets.rst
f621d65 
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
@bveeramani
Address review comments
91187a5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into ml-preprocessing-…
8d1ddbd 
…revisions

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update faq.rst
12e21b8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update nyc_taxi_basic_processing.ipynb
421d3d4 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update transforming-datasets.rst
789e10a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'ml-preprocessing-revisions' into remove-example
b32ecc2 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master' into remove-example
8bca667 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Fix changes
c61acc1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 14, 2023
@richardliaw richardliaw merged commit b87a803 into ray-project:master Mar 15, 2023
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request Mar 21, 2023
@bveeramani @angelinalg
@clarkzinzow @ProjectsByJackHe
[Datasets] Remove "Example: Large-scale ML Ingest" (ray-project#33067)
6f3469f 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
@bveeramani @angelinalg
@clarkzinzow @edoakes
[Datasets] Remove "Example: Large-scale ML Ingest" (ray-project#33067)
d6e5606 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request Mar 22, 2023
@bveeramani @angelinalg
@clarkzinzow @peytondmurray
[Datasets] Remove "Example: Large-scale ML Ingest" (ray-project#33067)
ab9f2e9 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
elliottower pushed a commit to elliottower/ray that referenced this pull request Apr 22, 2023
@bveeramani @angelinalg
@clarkzinzow @elliottower
[Datasets] Remove "Example: Large-scale ML Ingest" (ray-project#33067)
3fdb696 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: elliottower <elliot@elliottower.com>
ProjectsByJackHe pushed a commit to ProjectsByJackHe/ray that referenced this pull request May 4, 2023
@bveeramani @angelinalg
@clarkzinzow @ProjectsByJackHe
[Datasets] Remove "Example: Large-scale ML Ingest" (ray-project#33067)
0c2e295 
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Clark Zinzow <clarkzinzow@gmail.com>
Signed-off-by: Jack He <jackhe2345@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@c21 c21 c21 approved these changes

@richardliaw richardliaw richardliaw approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@clarkzinzow clarkzinzow Awaiting requested review from clarkzinzow

@jjyao jjyao Awaiting requested review from jjyao

@jianoaix jianoaix Awaiting requested review from jianoaix

Assignees

@scottjlee scottjlee

@clarkzinzow clarkzinzow

@amogkam amogkam

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bveeramani @richardliaw @c21 @scottjlee @clarkzinzow @amogkam